5
78%
master: 79%

Ran 17 Mar 2025 02:49PM UTC

Files 263

Run time 20s

Badge

Embed ▾

Committed 17 Mar 2025 02:42PM UTC coverage: 1.887% (+0.001%) from 1.886%

Job # 13902315391.5

Build Type

push

github

Committed by

jrfnl

Commit Message

Remove some redundant code

With the `MessageCollector` being used in the `Ruleset` class since PR 857, some guard code as introduced in 99 is no longer needed.

The guard code was in place to prevent the following situation:
* File under test contained an invalid `// phpcs:set` annotation which tried to set a non-existent property on a sniff.
* The  `File::process()` method would see this annotation and call the `Ruleset::setSniffProperty()` method to set the property.
* The `Ruleset::setSniffProperty()` method would throw an exception for the non-existent property.
* The exception would cause the `File` class to stop scanning the file, potentially leading to missing errors/warnings.

As the error for setting a non-existent property now no longer leads to an exception on a direct call to the `Ruleset::setSniffProperty()` method, we also no longer need to catch the exception and handle it from within the `File::process()` method.

In practice, this means that setting a non-existent property on a sniff via an inline `// phpcs:set` annotation will now be silently ignored (again) and will not affect the scan of the rest of the file.

This commit reverts 99.

Run Details

466 of 24700 relevant lines covered (1.89%)

0.03 hits per line

PHPCSStandards / PHP_CodeSniffer / 13902315391 / 5
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job cbf-os-ubuntu-latest-ubuntu-latest-php-8.4-custom-ini-false - 13902315391.5

PHPCSStandards / PHP_CodeSniffer / 13902315391 / 5 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job cbf-os-ubuntu-latest-ubuntu-latest-php-8.4-custom-ini-false - 13902315391.5

PHPCSStandards / PHP_CodeSniffer / 13902315391 / 5
78%
master: 79%

README BADGES
x