rust-bitcoin / rust-bitcoin / 13813702872 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#4229: feature: introduce MAX_BLOCK_SERIALIZED_SIZE to check limit

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e4513bf9250799bc18a10728af184d6c86a561a4">e4513bf92<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b18aa6f9d4ce7d29310a4922b9593c3135ad60b4"> feat: add MAX_BLOCK_SERIALIZED_SIZE existing in core (ChrisCho-H)

Pull request description:

  <a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fad0d9ea2d1e807806fa141238e279fddea6ae99">fad0d9ea2</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b18aa6f9d4ce7d29310a4922b9593c3135ad60b4">: add `MAX_BLOCK_SERIALIZED_SIZE` as constant, which also exists in [bitcoin-core](https://github.com/bitcoin/bitcoin/blob/</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/59ff17e5af4e382cbe16f183767beef1bdcd9131">59ff17e5a</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b18aa6f9d4ce7d29310a4922b9593c3135ad60b4">/src/consensus/consensus.h#L13).

  I originally thought it would be better to use this value for checking limit of push_bytes [here](https://github.com/rust-bitcoin/rust-bitcoin/blob/</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0870cd1660edd21739cc94075e4b3a1c7f1a7d15">0870cd166</a>/bitcoin/src/blockdata/script/push_bytes.rs#L31), as it's the actual limit(`OP_PUSHDATA4` semantic says it could allow up to 4GB though). However, I'm not sure whether there might be need to push_bytes larger than `MAX_BLOCK_SERIALIZED_SIZE`, so just let developer use this constant to check the actual limit rather than enforcing it.

ACKs for top commit:
  tcharding:
    ACK e4513bf9250799bc18a10728af184d6c86a561a4
  apoelstra:
    ACK e4513bf9250799bc18a10728af184d6c86a561a4; successfully ran local tests

Tree-SHA512: 44c5a4882b44aaf488671e47a11442b9183

21640 of 26057 relevant lines covered (83.05%)

16846.65 hits per line