1
78%
master: 80%

Ran 10 Mar 2025 05:10PM UTC

Files 33

Run time 51s

Badge

Embed ▾

Committed 10 Mar 2025 05:06PM UTC coverage: 77.729%. Remained the same

Job # 13770543461.1

Build Type

push

github

Committed by

web-flow

Commit Message

CA-408126 - rrd: Do not lose ds_min/max when adding to the RRD (#6349)

Rrd.ds_create has optional min and max arguments (defaulting to
neg_infinity and infinity respectively). Several callers would omit
these parameters, resulting in ds_min and ds_max being lost during the
conversion from Ds.ds to Rrd.ds. Without these, metrics couldn't be kept
in range, which would result in some (such as CPU usage numbers) going
negative when a domain would change its domid (over a reboot), for
example.

Make these parameters required, not optional. Requires adjusting unit
tests as well.

This latent behaviour was exposed during the major timestamp and plugin
refactoring last year.
Previously, the entire RRD was created at once by calling
create_fresh_rrd. Now create_fresh_rrd is only called for the first
chunk, and other chunks of the RRD call merge_new_dss, which omitted the
optional arguments. Rrdd_server.add_ds also ommitted these arguments,
which meant that datasources enabled at runtime would not be kept in
range.

Run Details

3354 of 4315 relevant lines covered (77.73%)

0.78 hits per line

xapi-project / xen-api / 13770543461 / 1
78%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 13770543461.1

xapi-project / xen-api / 13770543461 / 1 78% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 13770543461.1

xapi-project / xen-api / 13770543461 / 1
78%
master: 80%

README BADGES
x