7
78%
master: 79%

Ran 07 Mar 2025 10:15PM UTC

Files 262

Run time 12s

Badge

Embed ▾

Committed 07 Mar 2025 10:08PM UTC coverage: 75.84% (+0.005%) from 75.835%

Job # 13730200490.7

Build Type

push

github

Committed by

jrfnl

Commit Message

Squiz/FunctionSpacing: iterate on previous fix for attributes

Turns out the "silence the "before" error if the thing before was another function" functionality still wasn't working correctly.

And if there is a blank line between the first thing before the first "preamble" for the function and the declaration itself, the sniff would also disregard the "preamble" and insert the blank lines straight above the function declaration.

Fixed now.

Includes tests proving the bug.

Includes one minor change in the existing tests, where the recognition of "the thing before is also a function" no longer works.
This is a specific edge case when there are two functions declared on the same line and, in my opinion, this tiny regression is a valid trade-off for correctly handling functions with attributes, which is much more commonly found in code.

Run Details

18652 of 24594 relevant lines covered (75.84%)

25.68 hits per line

PHPCSStandards / PHP_CodeSniffer / 13730200490 / 7
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job os-ubuntu-latest-php-8.1-custom-ini-true - 13730200490.7

PHPCSStandards / PHP_CodeSniffer / 13730200490 / 7 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job os-ubuntu-latest-php-8.1-custom-ini-true - 13730200490.7

PHPCSStandards / PHP_CodeSniffer / 13730200490 / 7
78%
master: 79%

README BADGES
x