1
80%
master: 80%

Ran 26 Feb 2025 11:02AM UTC

Files 38

Run time 2min

Badge

Embed ▾

Committed 26 Feb 2025 10:00AM UTC coverage: 78.516%. Remained the same

Job # 13541476888.1

Build Type

push

github

Committed by

web-flow

Commit Message

Restructure valid allowed_operations computation (#6253)

In an effort to make the logic clearer, we restructure the part(s) of
`Xapi_pool_helpers` responsible for determining which operations are
"valid" (i.e. become members of `allowed_operations`).

The previous code is somewhat tedious to understand because it is
unconditionally ineffective - the logical delineation of parts of the
code is implicit, as the code computes the valid operation table in
order, but many of the operations will have no effect (as later code to
populate an operation's entry in the validity table do nothing).

This change makes the precedence of blocking and waiting operations more
apparent by explicitly casing on them (in decreasing order of
precedence). The differences are somewhat subtle and explained in the
commit message.

---

BVT+BST (211251) all green except for a few known issues. In a distant
future, the relation between operations could be stated declaratively
and the `allowed_operations` computed incrementally (based on ambient
state changes in the database, etc.).

The code populates a table with a tri-state value (allowed, unknown, and
disallowed). However, absence from the table could signify the same
(that the operation is valid), as every possible value is accounted for
(therefore, `Unknown` is redundant).

Run Details

3512 of 4473 relevant lines covered (78.52%)

0.79 hits per line

xapi-project / xen-api / 13541476888 / 1
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 13541476888.1

xapi-project / xen-api / 13541476888 / 1 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 13541476888.1

xapi-project / xen-api / 13541476888 / 1
80%
master: 80%

README BADGES
x