6
78%
master: 79%

Ran 13 Feb 2025 10:19PM UTC

Files 262

Run time 95min

Badge

Embed ▾

Committed 13 Feb 2025 10:10PM UTC coverage: 75.702%. Remained the same

Job # 13318052725.6

Build Type

push

github

Committed by

jrfnl

Commit Message

Squiz/ValidClassName: bug fix - improve comment handling

Noticed while working on something else.

If there would be a comment between the OO keyword and the declared name, the sniff could throw false positives with unhelpful error messages, like:
```
193 | ERROR | Class name "/*comment*/" is not in PascalCase format (Squiz.Classes.ValidClassName.NotCamelCaps)
 194 | ERROR | Trait name "//comment" is not in PascalCase format (Squiz.Classes.ValidClassName.NotCamelCaps)
 196 | ERROR | Interface name "// phpcs:ignore Stnd.Cat.SniffName -- just testing" is not in PascalCase format
     |       | (Squiz.Classes.ValidClassName.NotCamelCaps)
 199 | ERROR | Class name "CommentsShouldBeIgnoredValid/*comment*/" is not in PascalCase format (Squiz.Classes.ValidClassName.NotCamelCaps)
 200 | ERROR | Interface name "annotations_should_be_ignored_InvalidName" is not in PascalCase format (Squiz.Classes.ValidClassName.NotCamelCaps)
```

Fixed now by:
1. Ignoring any comments between the OO keyword and the name.
2. Not including comments directly following a name in the name to be evaluated.

Includes tests.

Includes minor error message precision fix - the error will now be thrown on the name which is being flagged as invalid, not on the OO keyword.

Run Details

18594 of 24562 relevant lines covered (75.7%)

25.39 hits per line

PHPCSStandards / PHP_CodeSniffer / 13318052725 / 6
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job os-ubuntu-latest-php-8.4-custom-ini-false - 13318052725.6

PHPCSStandards / PHP_CodeSniffer / 13318052725 / 6 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job os-ubuntu-latest-php-8.4-custom-ini-false - 13318052725.6

PHPCSStandards / PHP_CodeSniffer / 13318052725 / 6
78%
master: 79%

README BADGES
x