6
78%
master: 79%

Ran 10 Feb 2025 03:12PM UTC

Files 262

Run time 26min

Badge

Embed ▾

Committed 10 Feb 2025 03:05PM UTC coverage: 75.668% (+0.04%) from 75.627%

Job # 13243920103.6

Build Type

push

github

Committed by

jrfnl

Commit Message

Squiz/FunctionDeclarationArgumentSpacing: handle modifiers for constructor property promotion

The spacing after visibility/`readonly` modifiers for constructor property promotion were so far not checked by this sniff.

While the `Squiz.WhiteSpace.ScopeKeywordSpacing` sniff will already handle this, that sniff may not be in use in all standards using this sniff. As things were, this sniff was just no longer feature complete for the task this sniff is supposed to handle: spacing of function declaration arguments.

This commit adds handling the spacing after modifiers used for constructor property promotion to this sniff.

The spacing requirements are aligned with the spacing expectations of the `Squiz.WhiteSpace.ScopeKeywordSpacing` sniff, so the sniffs should not conflict with each other.

Additionally, the new checks in this sniff have dedicated error codes, which means that - if there would be a conflict anywhere - the modifier spacing checks within this sniff can easily be turned off.

Includes tests.

Run Details

18559 of 24527 relevant lines covered (75.67%)

25.37 hits per line

PHPCSStandards / PHP_CodeSniffer / 13243920103 / 6
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job os-ubuntu-latest-php-8.4-custom-ini-false - 13243920103.6

PHPCSStandards / PHP_CodeSniffer / 13243920103 / 6 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job os-ubuntu-latest-php-8.4-custom-ini-false - 13243920103.6

PHPCSStandards / PHP_CodeSniffer / 13243920103 / 6
78%
master: 79%

README BADGES
x