1
80%
master: 80%

Ran 31 Jan 2025 10:45AM UTC

Files 37

Run time 11s

Badge

Embed ▾

Committed 31 Jan 2025 10:31AM UTC coverage: 78.248%. Remained the same

Job # 13071134570.1

Build Type

push

github

Committed by

web-flow

Commit Message

CA-405593: Do not write extraneous data into the host certificate file (#6263)

When installing host certificates, the parser used accepts string with
random characters surrounding the PEM-encoded data. The ad-hoc parser
used to read the host certificate file was unable to parse them.

Because the PEM-encoded objects are copied as-is after validating them,
the ad-hoc parser fails to read the file correctly when xapi restarts.

This change fixes the issue by making sure that the written file's data
has been sanitized, by using parsed datastructures instead of
user-provided data.

    Parse, don't validate

I've manually tested the fix on a host, before and after to validate
that indeed now all the characters in between the PEM-encoded objects
are stripped

Run Details

3457 of 4418 relevant lines covered (78.25%)

0.78 hits per line

xapi-project / xen-api / 13071134570 / 1
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 13071134570.1

xapi-project / xen-api / 13071134570 / 1 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 13071134570.1

xapi-project / xen-api / 13071134570 / 1
80%
master: 80%

README BADGES
x