ndlib / honeycomb / 3495 / 1
96%
master: 95%

LAST BUILD BRANCH: DEC-1472-fix-bc-date-parsing
DEFAULT BRANCH: master
Ran
Files 208
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.018% (-0.09%) from 96.103%
2.1.5

push

travis-ci

jgondron 
DEC-1083:
- Created migrations to move honeypot data and image data into the Images entity.
- Added migration to rename the moved columns to *_save to prevent any accidental remains in application code from referencing the old fields
- Found an additional problem with the migration. Was not copying the raw json response into the new image.json_response field due to the HoneypotImage serialization. Overrriding the class in the migration to bypass this
- Fixed the migration to retain the old showcase/collection image fields. The current state of the application will not have these when we run the migrations, so they need to be preserved here.
DEC-1084:
-Image processing now happens within the Image object and its associated service classes, instead of in Item and it's services
- Removed custom preprocessing service classes. These were doing the following transforms, some of which are now handled in Image's paperclip styles:
  - Tiff -> jpg - This is still a problem with the original style, and not changing this until we can discuss what should be responsible for handling the tiffs (honeypot or honeycomb)
  - Gif -> png
  - Clamp to max pixels of 16m
- Fastimage gem was only needed inside of the preprocess image, which is no longer used
- SaveHoneypotImage now handles an Image object only, instead of the duck typed object it was handling before.
- Fixed image handling in collections, items and showcases.
- Fixed problems with the way we are creating new showcases and pages. The problem was with calling QueryObject.build with save_params, which was exposed now that we no longer have an uploaded_image on these objects. This also fixes DEC-850 for page creation.
- Fixed a problem with the thumbnail used on the showcase edit view. This was not using the honeypot thumbnails and should have been.
DEC-1094:
- Removed other derivatives. This means we no longer do any preprocessing at all on honeycomb. We store the original as is. So Honeypot will have to deal with the 16m pixel limit and tif->jpg, gif->png conversions if necessary. This does mean that openseadragon will fail in the dev environment if a developer uploads a tif since it will try to use the original file.

4027 of 4194 relevant lines covered (96.02%)

9.06 hits per line

Source Files on job 3495.1 (2.1.5)