rust-bitcoin / rust-bitcoin / 12970403617 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#3953: Refactor amounts

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/13a3f490b80e4c8f8e1753111a914315eefd73e6">13a3f490b<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/72e2b00721dc1e23c4e96cfbbbe3614f52c7984c"> Use Self instead of amount type (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/34e3049ae0ebe15f24be771f0ece3c72ee46ce5c">34e3049ae</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/72e2b00721dc1e23c4e96cfbbbe3614f52c7984c"> Use sats instead of satoshi (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/00b71a670fcedeca255e69fe5e3d08e5a9d1b72e">00b71a670</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/72e2b00721dc1e23c4e96cfbbbe3614f52c7984c"> Use from_sat_unchecked for hardcoded ints (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8fdec67f7dbf0d6a1766247168db8b53b8fb672c">8fdec67f7</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/72e2b00721dc1e23c4e96cfbbbe3614f52c7984c"> Change local var ua to sat (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c6f056672b20aa8970a544e5e7750d8e1c3a0fef">c6f056672</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/72e2b00721dc1e23c4e96cfbbbe3614f52c7984c"> Change local var sa to ssat (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f3e853e07a207bef1e63e4a5752c4af1bfc722b6">f3e853e07 units: Do trivial refactor of amount::tests (Tobin C. Harding)
dbec9807f Shorten identifiers by removing _in_sats (Tobin C. Harding)
154a4420f Stop using FQP on Amount type (Tobin C. Harding)
8e16a4825 Run the formatter (Tobin C. Harding)

Pull request description:

  Do a bunch of refactorings to tease out changes from #3794.

  The first 8 are uncontroversial. The 9th one is subjective. The last one is unusual but IMO worth doing because of the relationship between the two amount modules.

  Do note that this PR is 100% internal changes - please please don't bike shed this to death.

ACKs for top commit:
  apoelstra:
    ACK 13a3f490b80e4c8f8e1753111a914315eefd73e6; successfully ran local tests; lgtm

Tree-SHA512: e2ef0e7fb9398013cdb5f7523944de05b91

20958 of 25193 relevant lines covered (83.19%)

17347.58 hits per line