rust-bitcoin / rust-bitcoin / 12877217584 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#3926: units: Test for dyn compatibility

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/289a5214265a1f0d7b320b0121775f868a386c57">289a52142 units: Test for dyn compatibility (Tobin C. Harding)

Pull request description:

  Phew! dyn compatibility is a non-trivial concept. There are four public traits in `units`, only one is dyn compatible.

  This patch is done in order to check off C-OBJECT from the Rust API guidelines checklist.

  Add a test to check the public traits in `units` for dyn compatibility.

  While we are at it add a code comment on `Integer` stating why its not dyn-compatible.

  ref: https://rust-lang.github.io/api-guidelines/flexibility.html#c-object

ACKs for top commit:
  apoelstra:
    ACK 289a5214265a1f0d7b320b0121775f868a386c57; successfully ran local tests; nice!

Tree-SHA512: 6f247d4974478da75718797db91e77120da

20846 of 25094 relevant lines covered (83.07%)

17389.54 hits per line