1
80%
master: 80%

Ran 02 Jan 2025 10:24AM UTC

Files 37

Run time 1s

Badge

Embed ▾

Committed 02 Jan 2025 10:11AM UTC coverage: 78.273%. Remained the same

Job # 12580911951.1

Build Type

push

github

Committed by

web-flow

Commit Message

CA-404062: Wrongly restart xapi when receiving HTTP errors (#6201)

The xapi on a supporter host would restart when it received HTTP error
from the xapi on the coordinator host.

This breaks the pool.designate_new_master use case for a big pool, e.g.
64-host pool. In this case, some supporters may restart unexpectedly
within the phase of committing new coordinator due to the logic above.

Additionally, the purpose of this logic, explained by the error message,
is not correct also. Not all HTTP errors are caused by "our master
address is wrong".

On the other hand, if a use case requires to restart the xapi, an more
explicit logic should ensure that, instead of leveraging an implicit
HTTP error code. Furhtermore, if a supporter indeed is connecting to a
wrong coordinator, this should be a bug and can be recovered manually.

Based on above arguments, the restarting xapi after receiving HTTP error
is removed. This follows the TODO concluded in CA-36936 as well.

Run Details

3462 of 4423 relevant lines covered (78.27%)

0.78 hits per line

xapi-project / xen-api / 12580911951 / 1
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 12580911951.1

xapi-project / xen-api / 12580911951 / 1 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 12580911951.1

xapi-project / xen-api / 12580911951 / 1
80%
master: 80%

README BADGES
x