6 – native_toolchain_c_windows
74%
main: 74%

Ran 06 Dec 2024 11:12AM UTC

Files 25

Run time 0s

Badge

Embed ▾

Committed 06 Dec 2024 11:04AM UTC coverage: 79.006%. Remained the same

Subproject # native_toolchain_c_windows – 12197678865.6

Build Type

push

github

Committed by

web-flow

Commit Message

[native_assets_cli] Rename `supportedAssetTypes` to `buildAssetTypes` (#1786)

This PR changes the `supportedAssetTypes` to `buildAssetTypes`.

Hooks should not fail early if an asset type is not supported. This enables the following situations:

1. If some part of the Dart code requires an asset, but is not invoked transitively, the Dart code can still run in JIT, instead of failing on the build hook.
2. If an asset is not available, Dart code could fallback on a Dart implementation.
3. Hot reload hook invocations can omit the asset types that are not supported for hot reload (https://github.com/dart-lang/native/issues/1207#issuecomment-2505879943).

The PR changes both the Dart API and the JSON protocol. The JSON protocol passes and parses the old key for the time being to allow for a graceful transition until this rolls into a next Dart stable release and we can bump the lower SDK bound.

Side note:

* The refactorings somehow started disallowing version skew where an older SDK is used with a newer `package:native_assets_cli`, but we do allow this, we can fill in the blanks (see `pkgs/native_assets_cli/lib/src/model/build_config_CHANGELOG.md`). So this PR adds a lowest-parsable-version.

Run Details

858 of 1086 relevant lines covered (79.01%)

10.0 hits per line

dart-lang / native / 12197678865 / 6 – native_toolchain_c_windows
74%
main: 74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_toolchain_c_windows - 12197678865.6

dart-lang / native / 12197678865 / 6 – native_toolchain_c_windows 74% main: 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_toolchain_c_windows - 12197678865.6

dart-lang / native / 12197678865 / 6 – native_toolchain_c_windows
74%
main: 74%

README BADGES
x