Mu-L
/
PHPWord
/
11880214203
/
1
97%
develop: 97%
develop: 97%
|
Ran
|
Files
297
|
Run time
6s
|
Badge
Embed ▾
README BADGES
|
coverage: 96.91% (-0.3%) from 97.208%
push
github
web-flow[BUGFIX] Remove invalid tool call from composer `check` script (#2600) With commit [1] development dependencies have been removed from the `composer.json`, but not from the `composer.lock`. This indicates a inproper use of `composer` and should be taken care in review of pull-requests. A good practice here is to etablish a rule that composer commands needs to be added to the commit message and the pull-request. Other removed dependency and downgraded dependencies have been fixed or readded meanwhile, still missing the `phpcs` tool for the `check composer script`. The `CONTRIBUTION.md` states to execute `composer check` before creating a pull-request, which is literally broken due to the missing dependency. This change removes the php sniffer call from the check script. Additionally, the composer scripts are enhanced to use the same php binary used to invoke composer itself to mitigate issues using the wrong php version on systems with multiple php version binaries. Further consideration should be to use the check command in the Github Action workflow to have a border if development toolchain is gonna be broken with a change. [1] https://github.com/PHPOffice/PHPWord/commit/c3e34a0d2
11885 of 12264 relevant lines covered (96.91%)
33.23 hits per line
