3
78%
master: 79%

Ran 30 Oct 2024 05:32AM UTC

Files 262

Run time 6s

Badge

Embed ▾

Committed 30 Oct 2024 05:25AM UTC coverage: 70.143% (+0.005%) from 70.138%

Job # 11587556685.3

Build Type

push

github

Committed by

jrfnl

Commit Message

Generic/ConstructorName: fix minor bug

This commit fixes a minor bug in `Generic.NamingConventions
.ConstructorName` when checking if a given class has a parent. The code
was checking if the lower case version of the value returned by
`File::findExtendedClassName()`` is `false`. The problem is that
`strtolower()` never returns `false`, it always returns a `string`.
Thus, the condition would never evaluate to `true` and the sniff would
not bail at this point when a given class has no parent.

This did not cause any issues to the sniff, even for invalid code, as
there is not a scenario where a class method can have a `T_DOUBLE_COLON`
token followed by a `T_STRING` token with an empty `content`. This is
true even for empty strings as PHPCS includes the quotes in the
`content`.

Run Details

17103 of 24383 relevant lines covered (70.14%)

24.29 hits per line

PHPCSStandards / PHP_CodeSniffer / 11587556685 / 3
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 11587556685.3

PHPCSStandards / PHP_CodeSniffer / 11587556685 / 3 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 11587556685.3

PHPCSStandards / PHP_CodeSniffer / 11587556685 / 3
78%
master: 79%

README BADGES
x