6
61%
master: 63%

Ran 20 Oct 2024 03:30PM UTC

Files 80

Run time 2s

Badge

Embed ▾

Committed 20 Oct 2024 03:11PM UTC coverage: 60.448% (+0.08%) from 60.373%

Job # 5007988488929280.6

Build Type

push

CirrusCI

Committed by

SomberNight

Commit Message

interface: disable ssl.VERIFY_X509_STRICT for self-signed certs

The "ssl.VERIFY_X509_STRICT" flag for openssl verification has been enabled by default in python 3.13+ (it was disabled before that).
see https://github.com/python/cpython/issues/107361
and https://discuss.python.org/t/ssl-changing-the-default-sslcontext-verify-flags/30230/16

We explicitly disable it for self-signed certs, thereby restoring the pre-3.13 defaults,
as it seems to break lots of servers.

For example, using python 3.13 (or setting `sslc.verify_flags |= ssl.VERIFY_X509_STRICT`),
- I can connect to `btc.electroncash.dk:60002:s`
- but not to `electrum.emzy.de:50002:s`
despite both using self-signed certs.

We should investigate more why exactly "strict" verification fails for some self-signed certs and not for others,
and make sure that at least newly generated certs adhere to the stricter requirements (e.g. update guide in e-x?).

Run Details

19862 of 32858 relevant lines covered (60.45%)

0.6 hits per line

spesmilo / electrum / 5007988488929280 / 6
61%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5007988488929280.6

spesmilo / electrum / 5007988488929280 / 6 61% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5007988488929280.6

spesmilo / electrum / 5007988488929280 / 6
61%
master: 63%

README BADGES
x