bitcoindevkit / bdk / 11128359292 / 1

86%

master: 86%

push

github

Merge bitcoindevkit/bdk#1594: Replace trait `AnchorFromBlockPosition` with new struct

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/ab8068b90ee476f8edf7d3d4a21d621818e30969">ab8068b90 refactor(chain)!: Replace trait `AnchorFromBlockPosition` with new struct (Jiri Jakes)

Pull request description:

  ### Description

  This change replaces a way of creating new generic anchor from block and its height. Previous way was using conversion trait, newly it is a struct and `From`.

  Closes #1266.

  ### Notes to the reviewers

  - Removed `tx_pos`: I did not see its relevance (`Anchor` does not give access to it). Was it a relic from the past or something I overlooked?
  - I put `BlockPosition` into `tx_data_traits.rs` because I believe it should be next to `Anchor`. But then it's not a module just for traits. What would be better place?

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  LagginTimes:
    ACK ab8068b90ee476f8edf7d3d4a21d621818e30969
  LLFourn:
    ACK ab8068b90ee476f8edf7d3d4a21d621818e30969

Tree-SHA512: 9546ff177fe3b2962549a6c25da77cd1aea

11291 of 13671 relevant lines covered (82.59%)

14133.6 hits per line