xapi-project / xen-api / 11123005875 / 1
78%
master: 80%

LAST BUILD BRANCH: feature-PMCS-57239-XenServerUserAgent
DEFAULT BRANCH: master
Ran
Files 37
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.279%. Remained the same
11123005875.1

push

github

web-flow 
CP-51479: Optimize 'make install' (#5982)

We spend quite a lot of time here because dune is invoked multiple times
from different makefile rules, also install.sh was very verbose.

Draft PR to check github CI.

Running `make build install` with no changes to the code is ~3x faster
now:
```
Benchmark 1: rm /tmp/install/1 -rf; make -C ../scm-master build install DESTDIR=/tmp/install/1
  Time (mean ± σ):     20.575 s ±  0.239 s    [User: 13.093 s, System: 9.113 s]
  Range (min … max):   20.356 s … 21.064 s    10 runs

Benchmark 2: rm /tmp/install/2 -rf; make build install DESTDIR=/tmp/install/2
  Time (mean ± σ):      6.355 s ±  0.954 s    [User: 7.489 s, System: 5.320 s]
  Range (min … max):    5.827 s …  9.040 s    10 runs

Summary
  rm /tmp/install/2 -rf; make build install DESTDIR=/tmp/install/2 ran
    3.24 ± 0.49 times faster than rm /tmp/install/1 -rf; make -C ../scm-master build install DESTDIR=/tmp/install/1
```

20s for a noop incremental build was too slow, 6s is still slow, but
better.

And running just `make install` when there are no changes is about ~7x
faster now:
```
Benchmark 1: rm /tmp/install/2 -rf; make install DESTDIR=/tmp/install/2
  Time (mean ± σ):      2.791 s ±  0.075 s    [User: 4.469 s, System: 4.640 s]
  Range (min … max):    2.591 s …  2.863 s    10 runs
```

Koji build times are slightly improved too (~3m44s for buildArch phase
vs ~4m06s).

There are some changes in file permissions, but they look OK (e.g.
having execute permissions on the manpages was wrong to begin with):

<details>
<summary> Permission changes </summary>
```
--- refs	2024-09-16 09:24:17.408911755 +0100
+++ thiss	2024-09-16 09:24:17.415912441 +0100
@@ -1404,7 +1404,7 @@
 ./opt/xensource/bin/rrd2csv -rwxr-xr-x
 ./opt/xensource/bin/static-vdis -rwxr-xr-x
 ./opt/xensource/bin/update-ca-bundle.sh -rwxr-xr-x
-./opt/xensource/bin/xapi -r-xr-xr-x
+./opt/xensource/bin/xapi -rwxr-xr-x
 ./opt/xensource/bin/xapi-autostart-vms -rwxr-xr-x
 ./opt/xensource/bin/xapi-d... (continued)

3456 of 4415 relevant lines covered (78.28%)

0.78 hits per line

Source Files on job python3.11 - 11123005875.1