1
80%
master: 80%

Ran 01 Oct 2024 09:25AM UTC

Files 37

Run time 1s

Badge

Embed ▾

Committed 01 Oct 2024 09:10AM UTC coverage: 78.279%. Remained the same

Job # 11122434295.1

Build Type

push

github

Committed by

web-flow

Commit Message

CP-48676: Reuse pool sessions on slave logins (#5986)

This PR allows pool sessions to be reused, rather than wasting time
creating new ones each time to talk to the slaves.

The average time spent across 15 slave get_servertime xenapi calls on a
virtual pool was 20.97ms with reuse-pool-sessions = false.

![image](https://github.com/user-attachments/assets/a2cf31cb-5832-4e0d-928e-fc9df95626e6)
Compared to an average of 17.11ms with reuse-pool-sessions = true

![image](https://github.com/user-attachments/assets/186685a4-e763-449a-9f77-73cb29896200)

In particular, the part of the request that has actually been changed,
the login_no_password call has gone from about 2.41ms to 0.008ms, 300x
faster than previously.

One part of why this speedup is possible is because we no longer have to
do a pool.get_all for each session (to force the newly created session's
time to update). If we were to validate the reusable pool session is
valid before use, we would still need to do this pool.get_all. However,
as we are now no longer destroying the db session after use, it should
continue to be valid. As such, to achieve the best speed increase, this
option of validating the reusable pool session
(validate-reusable-pool-session in xapi.conf) is off by default.

Run Details

3456 of 4415 relevant lines covered (78.28%)

0.78 hits per line

xapi-project / xen-api / 11122434295 / 1
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 11122434295.1

xapi-project / xen-api / 11122434295 / 1 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 11122434295.1

xapi-project / xen-api / 11122434295 / 1
80%
master: 80%

README BADGES
x