bitcoindevkit / bdk / 11079667727 / 1
83%
master: 83%

DEFAULT BRANCH: master
Ran
Files 47
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.592%. Remained the same
11079667727.1

push

github

ValuedMammal 
Merge bitcoindevkit/bdk#1603: fix(RUSTSEC-2024-0370): proc-macro-error is unmaintained

d802d00a0 fix(RUSTSEC-2024-0370)!: bump `clap` to latest, removing transitive dependency on `proc-macro-error`. (Leonardo Lima)
45be3172a refactor(ci)!: update CI to build and test example in specific job (Leonardo Lima)
519728cd5 chore(examples)!: update all examples to have `example_` prefix (Leonardo Lima)
9b7b19586 chore: use path as `name` for cargo test targets (Leonardo Lima)
6e8f19607 fix(bdk_electrum): build with `--no-default-features` (Leonardo Lima)
33942ece8 fix(bdk_esplora): build with `--no-default-features` (Leonardo Lima)

Pull request description:

  A candidate for fixing #1593. It builds on top of #1615
  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  In https://github.com/bitcoindevkit/bdk/issues/1593 it's mentioned that `proc-macro-error` is unmaintained for the
  past few years, with no fix other than using proc-macro-error2 instead.

  As on our scenario it's merely a transitive dependency of `clap`,
  through `clap_derive` feature, which in latest releases doesn't depend on
  `proc-macro-error` we can just bump it to latest.

  It's valid to note that by bumping it, both examples that relies on clap
  are no longer MSRV (1.63) compliant.

  That said, this PR does:

  - Standardize the example packages to have `example_` prefix.
  - Exclude examples from running in main `Build & Test` CI job.
  - Add new testing step to `Build & Test Example` CI job.
  - Bumps the `clap` to `4.5.17`.

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of ... (continued)

11297 of 13678 relevant lines covered (82.59%)

14257.45 hits per line

Source Files on job 11079667727.1