Rise-Vision / rise-lit-components / 906fc054-d6ec-434e-bccb-337a0728338a / 1

96%

master: 96%

Pull #411

circleci

Chore/youtube allow embedding (#409)

* Variable and methods renaming [stage-2]

* Encapsulation of _parseLiveVideoId [stage-2]

* refactoring of how html messages are shown [stage-2]
All messages are fixed into the HTML now, and each message has it's own boolean to show or hide it.
This was necessary to better receive the not embeddable message, otherwise it would not be ideal.

* Not embeddable assessment and treatment [stage-2]

* Parse playabilityStatus and don't play if not "OK" [stage-2]
This is necessary because if the user enables the "Allow embedding" setting in the in-between state of the live stream, it will have a video ID and will be allowed to be embedded, then our polling will recognize as a valid video, but when the live stream starts the bug with Youtube will disable "Allow embedding" again and our player will get in an error status. We can prevent this by checking the playabilityStatus. It'll only be "OK" when the live stream actually started. So we will only play if the playabilityStatus is OK, meaning it's not in the in between state.

* Add channel thumbnail and Youtube logo [stage-2]

* Unit testing for the Allow embedding and thumbnail [stage-2]
AI has refactored this test file and added some unit tests, and I've added some unit tests also

* Version bump [stage-2]

* Fix lint error [stage-2]

* Fix formatting [stage-2]

2609 of 2718 branches covered (95.99%)

Branch coverage included in aggregate %.

14247 of 14785 relevant lines covered (96.36%)

39.97 hits per line