Ran
|
Files
47
|
Run time
2s
|
Badge
Embed ▾
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1601: fix(core): calling `CheckPoint::insert` with existing block must succeed <a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/3ae9ecba8c893750fa2ed5dfdbb1f4ee84a0b228">3ae9ecba8<a href="https://github.com/bitcoindevkit/bdk/commit/6d610bf495311af3454a56cbbf38edde3fcee037"> test: fix off-by-one in `checkpoint_insert_existing` (valued mammal) <a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/e6aeaea0c69472e4c2dcf0f5e2f632f43733529d">e6aeaea0c</a><a href="https://github.com/bitcoindevkit/bdk/commit/6d610bf495311af3454a56cbbf38edde3fcee037"> doc(core): document panic for `CheckPoint::insert` (valued mammal) </a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/2970b83f30ca7071f0502de395327eb3671a512b">2970b83f3</a> fix(core): calling `CheckPoint::insert` with existing block must succeed (志宇) Pull request description: ### Description Previously, we were panicking when the caller tried to insert a block at height 0. However, this should succeed if the block hash does not change. ### Notes to the reviewers For context: * https://github.com/lightningdevkit/ldk-node/pull/358 * https://discord.com/channels/753336465005608961/978744259693916230/1283050849429356629 ### Changelog notice * Fix `CheckPoint::insert` to not panic when inserting existing genesis block (same block height and hash). ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### Bugfixes: ~~* [ ] This pull request breaks the existing API~~ * [x] I've added tests to reproduce the issue which are now passing ACKs for top commit: ValuedMammal: Self ACK 3ae9ecba8c893750fa2ed5dfdbb1f4ee84a0b228 notmandatory: ACK 3ae9ecba8c893750fa2ed5dfdbb1f4ee84a0b228 Tree-SHA512: 638d8aacab3f9364045a77909d31a0b0e55
11314 of 13701 relevant lines covered (82.58%)
13998.54 hits per line
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|