bitcoindevkit / bdk / 10813593075 / 1

83%

master: 83%

push

github

Merge bitcoindevkit/bdk#1597: fix(wallet): do `check_wallet_descriptor` when creating and loading

<a class=hub.com/bitcoindevkit/bdk/commit/5aecf4d6c48b75e610bbb9e31ad552878d797b5c">5aecf4d6c fix(wallet): do `check_wallet_descriptor` when creating and loading (valued mammal)

Pull request description:

  Do `check_wallet_descriptor` for both external and internal descriptors when creating a wallet, and as a defensive measure also perform the check on the descriptors loaded from a changeset.

  fixes #1557

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK 5aecf4d6c48b75e610bbb9e31ad552878d797b5c

Tree-SHA512: c1503cc03df8ff85c9401a6a1b76103cdad

11103 of 13584 relevant lines covered (81.74%)

14071.48 hits per line