bitcoindevkit / bdk / 10617530998 / 1

83%

master: 83%

push

github

Merge bitcoindevkit/bdk#1425: chore: add `print_stdout`/`print_stderr` lints to workspace level

<a class=hub.com/bitcoindevkit/bdk/commit/e063ad89bde62e60b10435260e736c66515bf447">e063ad89b<a href="https://github.com/bitcoindevkit/bdk/commit/a8d52e658bd45eacca683b36d516950b40bb73e5"> fix(esplora+wallet+file_store): remove remaining `println!` usage (Leonardo Lima)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/b32b9447e089709b66f24d5700750f0aa6b8d6e1">b32b9447e</a><a href="https://github.com/bitcoindevkit/bdk/commit/a8d52e658bd45eacca683b36d516950b40bb73e5"> chore(examples): allow `clippy::print_stdout` in examples (Leonardo Lima)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/b614237127ec1e760414fcc8ee7c4b0c77c62d46">b61423712</a><a href="https://github.com/bitcoindevkit/bdk/commit/a8d52e658bd45eacca683b36d516950b40bb73e5"> fix(tests)!: remove println! usage from tests (Leonardo Lima)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/eaa1917a46245e177ad3e65b53e34c681f0043d0">eaa1917a4</a> chore: add `print_stdout`/`print_stderr` lints to workspace level (Leonardo Lima)

Pull request description:

  potentially fixes #1362
  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  It adds both `print_stdout` and `print_stderr` deny level lints on workspace level, but it does allow it on test fns through `clippy.toml` settings, and explicitly allow it on example code.

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers
  It currently has the setting allowing it on test fns, but open for discussion below.

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  - Add both `print_stdout` and `print_stderr` deny level lints on workspace level

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  notmandatory:
    ACK e063ad89bde62e60b10435260e736c66515bf447

Tree-... (continued)

11213 of 13665 relevant lines covered (82.06%)

14317.37 hits per line