bitcoindevkit / rust-esplora-client / 10514244019 / 1

88%

master: 88%

push

github

Merge bitcoindevkit/rust-esplora-client#90: Don't return 1.0 feerate if none is found by `convert_fee_rate`

<a class=hub.com/bitcoindevkit/rust-esplora-client/commit/ec5ee8233011269b2d0bbdf8a1647e27e61b9050">ec5ee8233<a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/d008b9b24cfd0e366728b3db52e6736447bfbb8b"> test: improve test `feerate_parsing` (valued mammal)
<a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/ed219e29455a9d38487f50d3862888b73cdb211c">ed219e294</a> fix: don't return default 1.0 feerate if not found by `convert_fee_rate` (valued mammal)

Pull request description:

  Change `convert_fee_rate` to return `Option<f32>` instead of Result.

  PR #65 made this function effectively infallible by removing the parse int error while falling back to a bogus 1.0 feerate if a value isn't found in fee estimates. We could make it return an error if for example the given fee estimates map is empty without changing the function signature but in that case we would need a new `Error` variant making it a breaking change anyway, therefore just change the function to return `Option` which should only be `None` if given a target of 0 or an empty map assuming esplora always has a fee estimate for a target of 1 confirmation.

  fixes #80

ACKs for top commit:
  notmandatory:
    ACK ec5ee8233011269b2d0bbdf8a1647e27e61b9050

Tree-SHA512: 32fd2a8a58afe6f092c5e2538108f8a9bcb

1060 of 1211 relevant lines covered (87.53%)

8.55 hits per line