3
87%
dev: 88%

Ran 31 May 2016 06:20PM UTC

Files 42

Run time 3s

Badge

Embed ▾

Committed 31 May 2016 06:13PM UTC coverage: 85.535% (-0.8%) from 86.33%

Job # TEST_TIMEOUT_SCALE=20

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Fix races caused by closing sendCh

We have multiple goroutines possibly writing to sendCh, so closing
sendCh causes races unless we add a ton of synchronization between
the goroutines.

In the relay path, we really don't want to add synchronization overhead
for every frame we're handling. The much simpler option is to avoid
closing sendCh, and instead use a separate channel to signal that the
writeFrames goroutine to end. The sendCh will be cleaned up by the
GC automatically when there's no references left to the channel.

It's possible to simplify (and reduce synchronization) in the standard
call path after this change, which can be done separately if we get a
performance benefit. Since the standard call path does much more than
the relay path, it is likely not going to affect performance as much.

Run Details

3672 of 4293 relevant lines covered (85.53%)

2708.29 hits per line

uber / tchannel-go / 1970 / 3
87%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1970.3 (TEST_TIMEOUT_SCALE=20)

uber / tchannel-go / 1970 / 3 87% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1970.3 (TEST_TIMEOUT_SCALE=20)

uber / tchannel-go / 1970 / 3
87%
dev: 88%

README BADGES
x