1
78%
master: 79%

Ran 13 Aug 2024 06:22PM UTC

Files 260

Run time 10s

Badge

Embed ▾

Committed 13 Aug 2024 06:14PM UTC coverage: 69.804% (+0.004%) from 69.8%

Job # 10375015156.1

Build Type

push

github

Committed by

jrfnl

Commit Message

Squiz/EmbeddedPhp: fix false positive when handling short open tags

The content of a PHP long open tag token is `<?php ` (note
the space after the tag). The content of a PHP short open tag is
`<?` (no space after the tag). The sniff did not account correctly for
this difference when checking the expected number of spaces after a
short open tag, resulting in false positives and incorrect fixes.

For example, the code below:

```
<? echo 'one space after short open tag'; ?>
```

Resulted in the error (there is just one space after the opening tag and
not two, as stated in the error):

```
Expected 1 space after opening PHP tag; 2 found (Squiz.PHP.EmbeddedPhp.SpacingAfterOpen)
```

And the incorrect fix:

```
<?echo 'without space after short open tag'; ?>
```

This commit fixes this problem by changing the sniff code to consider
that only long open tags contain a space after the tag in the `content`
key of the token array.

Run Details

16963 of 24301 relevant lines covered (69.8%)

23.78 hits per line

PHPCSStandards / PHP_CodeSniffer / 10375015156 / 1
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 10375015156.1

PHPCSStandards / PHP_CodeSniffer / 10375015156 / 1 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 10375015156.1

PHPCSStandards / PHP_CodeSniffer / 10375015156 / 1
78%
master: 79%

README BADGES
x