4
87%
dev: 88%

Ran 27 May 2016 10:14PM UTC

Files 42

Run time 2s

Badge

Embed ▾

Committed 27 May 2016 10:09PM UTC coverage: 86.009% (+0.9%) from 85.132%

Job # TEST_TIMEOUT_SCALE=20

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Only add new active connections if channel is active

We previously checked if the channel was active using a read lock, but
this could go stale, as the channel could be closed between the time the
check was done and the connection being added -- and the connection
would be left in an active state, causing the channel to never close.

To avoid this, we now check the state and add the connection atomically.

If the connection is not added, it means the channel is closed, and so
we close the connection to avoid leaving a rogue TCP connection.

Run Details

3713 of 4317 relevant lines covered (86.01%)

2617.4 hits per line

uber / tchannel-go / 1955 / 4
87%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1955.4 (TEST_TIMEOUT_SCALE=20)

uber / tchannel-go / 1955 / 4 87% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1955.4 (TEST_TIMEOUT_SCALE=20)

uber / tchannel-go / 1955 / 4
87%
dev: 88%

README BADGES
x