bitcoindevkit / bdk / 10243132737 / 1

83%

master: 83%

push

github

Merge bitcoindevkit/bdk#1523: bdk_wallet: Don't reimplement descriptor checksum, use the one from rust-miniscript

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/70c7d6b1c064103b359ad2e774a2648fbd85a414">70c7d6b1c<a href="https://github.com/bitcoindevkit/bdk/commit/61237789a63ed51d5bf198dc69b77db82b9cbfb4"> bdk_wallet: remove unnecessary calls to calc_checksum (Antoine Poinsot)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/8245fb7eabb3aa9747118cc871dca4646be4d6e8">8245fb7ea</a><a href="https://github.com/bitcoindevkit/bdk/commit/61237789a63ed51d5bf198dc69b77db82b9cbfb4"> bdk_wallet: don&#39;t reimplement checksum algorithm, use rust-miniscript (Antoine Poinsot)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/a11ace20ce38c9753d7f58cd410da747f4e4fd00">a11ace20c</a> bdk_wallet: descriptor: remove unnecessary call to calc_checksum_bytes (Antoine Poinsot)

Pull request description:

  Skimming through the BDK code today i noticed the descriptor checksum algorithm is re-implemented instead of using the implementation from rust-miniscript. Re-implementing it here is more code to review and maintain, more room for mistakes and overall less eyes over the code than centralizing a single implementation over at `rust-miniscript`.

  While doing this i noticed that one of the variants was completely unnecessary (`calc_checksum_bytes`), so i removed it. I realise it's breaking the API, so if we want to avoid that i can remove this part. I also added a commit to remove redundant calls to `calc_checsum`.

  Overall this is just a quick PoC as i noticed it i figured i'd send a PR, my bad if i missed anything!

ACKs for top commit:
  storopoli:
    utACK 70c7d6b1c064103b359ad2e774a2648fbd85a414
  evanlinjin:
    ACK 70c7d6b1c064103b359ad2e774a2648fbd85a414

Tree-SHA512: 89d0e5829ff1e9236e1a28c93122e41c86b

10895 of 13317 relevant lines covered (81.81%)

14907.68 hits per line