2
78%
master: 79%

Ran 01 Aug 2024 08:42PM UTC

Files 260

Run time 9s

Badge

Embed ▾

Committed 01 Aug 2024 08:35PM UTC coverage: 72.405% (-0.006%) from 72.411%

Job # 10205403704.2

Build Type

push

github

Committed by

jrfnl

Commit Message

AbstractPatternSniff: prevent PHP notice

In a live coding situation, the token triggering the pattern being looked for could be at or near the end of the file.
This could lead to a situation where the pattern could never match anyhow as there are not enough tokens left in the file to match against.

In this situation, the sniff could trigger the following PHP error:
```
Increment on type bool has no effect, this will change in the next major version of PHP in path/to/phpcs/src/Sniffs/AbstractPatternSniff.php on line 627
```

This commit prevents this error by bowing out early if there are not enough tokens in the file under scan to match the pattern.

Tested via the `Squiz.Functions.FunctionDeclaration` sniff via which this issue was discovered.

Run Details

17517 of 24193 relevant lines covered (72.41%)

23.93 hits per line

PHPCSStandards / PHP_CodeSniffer / 10205403704 / 2
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.1-custom-ini-true - 10205403704.2

PHPCSStandards / PHP_CodeSniffer / 10205403704 / 2 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.1-custom-ini-true - 10205403704.2

PHPCSStandards / PHP_CodeSniffer / 10205403704 / 2
78%
master: 79%

README BADGES
x