3
97%
master: 97%

Ran 23 May 2016 06:28PM UTC

Files 10

Run time 0s

Badge

Embed ▾

Committed 23 May 2016 06:24PM UTC coverage: 96.352% (+0.02%) from 96.328%

Job # 194.3

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Fix the 'Bool' method output by checking the field value (#53)

* Fix #52 by checking the field value in Bool method

>> According to the issue #52, the logger was always reporting a boolean
>> key-value pair as 'true'.

>> It was happening because of the hardcoded field value as 1, in the file
>> ['field.go'](https://github.com/uber-go/zap/blob/master/field.go#L55).

>> Test cases were unable to detect it probably because the test case is
>> giving input [only
>> as](https://github.com/uber-go/zap/blob/master/field_test.go#L75-L78)
>> 'true' type.

* Use golang's zero-values to pass the Travis build

* Add unit tests for Bool method in field.go

Methods 'TestTrueBoolField' and 'TestFalseBoolField' will check for
equality of expected and returned boolean values
(true and false respectively).

Method 'TestUnlikeBoolField' will check for unequality of different
boolean value pairs.

Coverage Stats

449 of 466 relevant lines covered (96.35%)

13396.51 hits per line

uber-go / zap / 194 / 3
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 194.3

uber-go / zap / 194 / 3 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 194.3

uber-go / zap / 194 / 3
97%
master: 97%

README BADGES
x