rust-bitcoin / rust-bitcoin / 9994647367 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#3064: Remove public error re-export

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/beea3c1e5d9b8ea9970ac6a4c4d4cde3462f83ef">beea3c1e5 Remove public error re-export (Tobin C. Harding)

Pull request description:

  We do not have a policy to re-export things from other modules just because they are in the public API - I don't see any other reason to re-export this error, users should go to the `validation` module directly to get the error type.

  Raising this trivial change as a separate PR so that we can really pin down our re-export policy. Please review the policy implications as well as the code change.

  Note please that this change was introduced in 7d695f6b4 by me, and buried in a PR that did not mention the change. This was wrong, as in the code change was wrong and also the patching method was wrong.

ACKs for top commit:
  Kixunil:
    ACK beea3c1e5d9b8ea9970ac6a4c4d4cde3462f83ef

Tree-SHA512: 5fc072f3fe62937c71493c39f498815fdc5

19669 of 23629 relevant lines covered (83.24%)

15689.26 hits per line