1
53%
main: 53%

Ran 17 Jul 2024 02:11PM UTC

Files 215

Run time 5s

Badge

Embed ▾

Committed 17 Jul 2024 02:04PM UTC coverage: 54.393% (+0.08%) from 54.311%

Job # 9975725330.1

Build Type

push

github

Committed by

web-flow

Commit Message

Fix potential race condition in rule type engine cache (#3918)

This addresses a potential race condition I discovered while working on
another task. If a rule instance with a new rule type is added to a
profile after the rule type cache is populated, but before the profiles
and rule instances are queried, the evaluation will fail because the new
rule type will be missing from the cache.

This changes the logic to query for rule types which are not found in
the cache, and create a new rule type engine instance and cache it if we
get a result.

*Alternatives Considered*

I could simplify this to remove the pre-population and query the
database for each rule type when we encounter it first. This would
simplify the logic, but at the expense of throwing away the performance
gains from loading most of the rules we need in one query.

Run Details

12115 of 22273 relevant lines covered (54.39%)

47.9 hits per line

stacklok / minder / 9975725330 / 1
53%
main: 53%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9975725330.1

stacklok / minder / 9975725330 / 1 53% main: 53%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9975725330.1

stacklok / minder / 9975725330 / 1
53%
main: 53%

README BADGES
x