xapi-project / xen-api / 9936100414 / 2
80%
master: 80%

DEFAULT BRANCH: master
Ran
Files 14
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 51.4%. Remained the same
9936100414.2

push

github

web-flow 
CP-50078: Instrument xapi-storage-script with tracing (#5808)

* CP-50078: Check if SMAPI observation is enabled

Modifies xapi-storage-script to determine if SMAPI observation is enabled by
checking whether a configuration file exists for it within the file system.

Internally, xapi queries the database to determine if a specific component
should be observed but as xapi-storage-script is an external daemon, we rely
on the file system.

To avoid modifying much of the monadic structure, a configuration record is
used to record whether observation is enabled. It is hoped this less invasive
change will make it simpler to rework xapi-storage-script in the future.

The path of the observer configuration directory is relocated to xapi-consts.

Signed-off-by: Colin James <colin.barr@cloud.com>

* CP-50078: Augment RPC transport to use observer.py

Modifies the RPC transport (fork_exec_rpc) to take a "dbg" parameter that can
encode a traceparent. If observation is enabled and a traceparent can be parsed
from the dbg parameter, the storage plugin's script will be invoked via
observer.py (for automatic instrumentation).

This change does not yet seed each of the transports with the dbg parameter;
the volume, datapath, etc. interfaces - defined in xapi-storage - use the
convention of having dbg as the first parameter for each RPC function.

The act of supplying this dbg parameter to the transport could be done
implicitly, but this would be a contract that is hard to enforce, despite
vastly reducing the pervasiveness of changes to come; each handler will need to
partially apply its received dbg parameter to the RPC transport (e.g.
volume_rpc ~dbg) at each usage site.

The python3 path is relocated from xapi_globs.ml to become a constant within
xapi-consts.

Signed-off-by: Colin James <colin.barr@cloud.com>

* CP-50078: Augment RPC transports for tracing

This change is rather pervasive but it seeds the volume and datapath... (continued)

991 of 1928 relevant lines covered (51.4%)

0.51 hits per line

Source Files on job python3.11 - 9936100414.2