realm / realm-core / 2482 / 1

91%

master: 91%

push

Evergreen

Fix data races in the connection state changes tests (#7871)

The assignment to token1 on the main thread and the read of it on the sync
worker thread didn't have any intervening synchronization and in theory the
callback could read it before it's actually written. Fixing this requires
adding some locking.

Conversely, listener2 doesn't actually need to be atomic since the second
callback should only ever be invokved synchronously inside log_out(), and if
it's called at some other time that's a bug.

It doesn't matter here, but `listener1_call_cnt = listener1_call_cnt + 1` is a
nonatomic increment that will drop updates if it happens on multiple threads at
once, while `++` will not.

96024 of 178092 branches covered (53.92%)

210537 of 232214 relevant lines covered (90.67%)

2950317.2 hits per line