2
78%
master: 79%

Ran 09 Jul 2024 05:20AM UTC

Files 260

Run time 5s

Badge

Embed ▾

Committed 09 Jul 2024 05:14AM UTC coverage: 72.328% (+0.007%) from 72.321%

Job # 9851378995.2

Build Type

push

github

Committed by

jrfnl

Commit Message

Generic/DisallowSpaceIndent: flag heredoc/nowdoc closer using space indent

This is the same fix for the `Generic.WhiteSpace.DisallowSpaceIndent` sniff as was previously made in squizlabs/PHP_CodeSniffer 3640 and 533 for the sister-sniff `Generic.WhiteSpace.DisallowTabIndent`.

---

Since PHP 7.3, heredoc/nowdoc closers may be indented.
This indent can use either tabs or spaces and the indent is included in the `T_END_HEREDOC`/`T_END_NOWDOC` token contents as received from the PHP native tokenizer.

However, these tokens were not included in the tokens to look at for the `Generic.WhiteSpace.DisallowSpaceIndent` sniff, which could lead to false negatives.

Fixed now, includes tests.

And along the same lines as per 533:
* The error for space indentation of heredoc/nowdoc closers is not auto-fixable to prevent the fixer creating parse errors as the indentation of the _contents_ of the heredoc/nowdoc has to be the same as for the closer.
* The error for space indentation of heredoc/nowdoc closers has its own error code to allow for selectively ignoring the indentation of heredoc/nowdoc closers.

Run Details

17494 of 24187 relevant lines covered (72.33%)

23.87 hits per line

PHPCSStandards / PHP_CodeSniffer / 9851378995 / 2
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.1-custom-ini-true - 9851378995.2

PHPCSStandards / PHP_CodeSniffer / 9851378995 / 2 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.1-custom-ini-true - 9851378995.2

PHPCSStandards / PHP_CodeSniffer / 9851378995 / 2
78%
master: 79%

README BADGES
x