1
80%
master: 80%

Ran 09 Jul 2024 12:26AM UTC

Files 274

Run time 5s

Badge

Embed ▾

Committed 03 Jul 2024 08:33PM UTC coverage: 61.437% (-0.08%) from 61.518%

Job # 2413.1

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Avoid consuming ByteBuffers (#913)

A ByteBuffer is a pointer to a byte[] with a starting position, a current position, and a limit. Any function that reads from its contents updates the current position. Both TracingPropagator and WorkflowUtils copy the entirety of its contents, and in doing so they mutate the current position. WorkflowUtils resets it afterwards but this still isn't thread-safe as another thread may be trying to read it.

By duplicating the ByteBuffer (copying only the metadata, not the actual contents) we avoid modifying it. It doesn't seem likely that there's real impact in either of these cases beyond unit tests, where these ByteBuffers stick around in the workflow history and are repeatedly serialized/deserialized. Modifying them during serialization can create test flakiness as that can trigger exceptions.

Run Details

11966 of 19477 relevant lines covered (61.44%)

0.61 hits per line

uber / cadence-java-client / 2413 / 1
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2413.1

uber / cadence-java-client / 2413 / 1 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2413.1

uber / cadence-java-client / 2413 / 1
80%
master: 80%

README BADGES
x