1
90%
main: 90%

Ran 07 Jul 2024 01:57AM UTC

Files 37

Run time 0s

Badge

Embed ▾

Committed 07 Jul 2024 01:43AM UTC coverage: 88.959% (+0.1%) from 88.862%

Job # 9823737208.1

Build Type

push

github

Committed by

Krinkle

Commit Message

HTML Reporter: Fix encoding of label for urlConfig multi-value item

* Add test coverage for QUnit.config.urlConfig items with object
  as value. The urlConfig feature is mostly covered by
  `/test/reporter-urlparams.html` already, but what isn't covered yet
  is an item with an object value, where option labels can be
  customised.

* In adding tests I noticed that, when urlConfig is used to create
  a multi-value option (rather than string, as is more common), then
  `val.label` was not escaped, which meant that if labels were to
  contain mention of an HTML tag or otherwise contain "<" and ">",
  these could glitch and break part of the toolbar rendering.
  This is unlikely to be exploitable, e.g. not controlled by
  URL parameters, and generally populated with literals. Even dynamic
  menus that feed dropdown contents from external input are fine,
  since this affects the top-level label only.

Improve docs:
* Avoid the overloaded word "option". Instead using the word "item"
  consistently when referring to urlConfig items,
  to avoid confusion with the `<select>` options inside of the array.
* Remove odd inline snippet using `value = ;`. This was solely to
  satisfy ESLint run on Markdown, but is simply confusing. The array
  was redundant with the full example lower down, and I've now added
  a full example with an object value as well.

Run Details

1829 of 2056 relevant lines covered (88.96%)

2136.68 hits per line

qunitjs / qunit / 9823737208 / 1
90%
main: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9823737208.1

qunitjs / qunit / 9823737208 / 1 90% main: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9823737208.1

qunitjs / qunit / 9823737208 / 1
90%
main: 90%

README BADGES
x