realm / realm-core / 2443 / 1

91%

master: 91%

push

Evergreen

Fix compacting a Realm file using the existing encryption key (#7844)

`compact()` stored the existing encryption key in a `std::string`, which
expects a nul-terminated string, not a fixed-size buffer. If the key contained
any nul bytes then the key would be truncated and garbage data would be used as
the encryption key instead, and if it didn't then arbitrarily large additional
amounts of memory would also be copied into the buffer. The tests happened to
always use a nul-terminated string as the key and so worked by coincidence.

95926 of 178028 branches covered (53.88%)

210135 of 231814 relevant lines covered (90.65%)

2977580.01 hits per line