bitcoindevkit
/
bdk
/
9668400638
/
1
83%
master: 83%
master: 83%
|
Ran
|
Files
44
|
Run time
1s
|
Badge
Embed ▾
README BADGES
|
coverage: 83.034% (+0.01%) from 83.024%
push
github
notmandatoryMerge bitcoindevkit/bdk#1424: Remove trait ComputeSighash 55a17293a ref(signer): Use `Psbt::sighash_ecdsa` for computing sighashes (valued mammal) f2a2dae84 refactor(signer): Remove trait ComputeSighash (valued mammal) Pull request description: This PR does some cleanup of the `bdk_wallet` signer module most notably by removing the internal trait `ComputeSighash` and replacing old code for computing the sighash (for legacy and segwit context) with a single method [`Psbt::sighash_ecdsa`](https://docs.rs/bitcoin/0.31.2/bitcoin/psbt/struct.Psbt.html#method.sighash_ecdsa). The logic for computing the taproot sighash is unchanged and extracted to a new helper function `compute_tap_sighash`. - [x] Unimplement `ComputeSighash` - [x] Try de-duplicating code by using `Psbt::sighash_ecdsa`. see https://github.com/bitcoindevkit/bdk/pull/1023#discussion_r1263140218 - Not done in this PR: Consider removing unused `SignerError` variants fixes #1038 ### Notes to the reviewers ### Changelog notice ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing Top commit has no ACKs. Tree-SHA512: 56af3c9c4c09c824a78ea1adabbcc99d3cd
11051 of 13309 relevant lines covered (83.03%)
16967.94 hits per line
