1
96%
master: 97%

Ran 17 May 2016 05:11AM UTC

Files 10

Run time 0s

Badge

Embed ▾

Committed 17 May 2016 05:00AM UTC coverage: 96.466% (+0.1%) from 96.328%

Job # 182.1

Build Type

push

travis-ci

Committed by

akshayjshah

Commit Message

Reduce allocations for disabled/sampled logs

Even when a log level is disabled or heavily sampled, calling
`logger.Error(msg, someField, someOtherField)` will make at least one
allocation to hold the fields. If we're using the more expensive field
types, we may allocate even more, only to discard all that work.

This PR introduces the `logger.Check` API, which allows particularly
performance-sensitive applications to avoid these allocations by using
a slightly wordier call pattern.

Using `Check` makes it virtually free to pass fields to a sampled
logger:

```
BenchmarkZapDisabledLevelsAddingFields-4         3000000        439 ns/op             704 B/op          2 allocs/op
BenchmarkZapDisabledLevelsCheckAddingFields-4   200000000         5.74 ns/op            0 B/op          0 allocs/op

BenchmarkZapSampleWithoutFields-4       20000000                60.9 ns/op             0 B/op          0 allocs/op
BenchmarkZapSampleCheckWithoutFields-4  20000000                61.4 ns/op             0 B/op          0 allocs/op

BenchmarkZapSampleAddingFields-4         2000000               575 ns/op             704 B/op          2 allocs/op
BenchmarkZapSampleCheckAddingFields-4   20000000                65.2 ns/op             0 B/op          0 allocs/op
```

Run Details

464 of 481 relevant lines covered (96.47%)

12968.02 hits per line

uber-common / zap / 182 / 1
96%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 182.1

uber-common / zap / 182 / 1 96% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 182.1

uber-common / zap / 182 / 1
96%
master: 97%

README BADGES
x