3
99%
master: 99%

Ran 13 Jun 2024 05:34PM UTC

Files 28

Run time 1s

Badge

Embed ▾

Committed 13 Jun 2024 05:32PM UTC coverage: 99.602% (-0.1%) from 99.701%

Job # 9504163554.3

Build Type

push

github

Committed by

web-flow

Commit Message

[fix] Prevent sending multiple identical notifications #277

If a user is in several organizations,
they will receive multiple identical notifications.
The reason for this is that the database query,
which determines which user should receive the notification,
does a LEFT OUTER JOIN with the "openwisp_users_organizationuser" table.
In this table, a user is multiple times listed,
when he is in several organizations.
Therefore the query returns such a user multiple times,
which will then receive multiple identical notifications.
This commit fixes this bug by adding a distinct to all user queries.

Fixes #277

Signed-off-by: Konrad Kreitmair <kkreitmair@tdt.de>

Run Details

1001 of 1005 relevant lines covered (99.6%)

1.0 hits per line

openwisp / openwisp-notifications / 9504163554 / 3
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python-3.9-django~=3.2.0 - 9504163554.3

openwisp / openwisp-notifications / 9504163554 / 3 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python-3.9-django~=3.2.0 - 9504163554.3

openwisp / openwisp-notifications / 9504163554 / 3
99%
master: 99%

README BADGES
x