rust-bitcoin / rust-bitcoin / 9441286520 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#2845: fix ServiceFlags::remove

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/0949be931abbeb39e53ed6c3b10cb77ef60f2911">0949be931 fix ServiceFlags::remove (Antoni Spaanderman)

Pull request description:

  Contrary to the documentation and the method name, this function does an XOR operation, if there are no flags in `self`, flags from `other` are added.

  What should happen to the core::ops::BitXor{,Assign} implementations? I did not touch them because it would break current API usage and would require a minor version bump (on 0.x.y versions).

ACKs for top commit:
  Kixunil:
    ACK 0949be931abbeb39e53ed6c3b10cb77ef60f2911
  apoelstra:
    ACK 0949be931abbeb39e53ed6c3b10cb77ef60f2911 looks good. I think it is fine to retain a BitXor impl on a flag type, even if it is questionably useful

Tree-SHA512: d73853e5f861759b099827a404294418e8e

19487 of 23403 relevant lines covered (83.27%)

16546.33 hits per line