Ran
|
Files
45
|
Run time
1s
|
Badge
Embed ▾
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1386: Remove TxBuilder allow_shrinking() and unneeded context param 096b8ef78 fix(wallet): remove TxBuilder::allow_shrinking function and TxBuilderContext (Steve Myers) Pull request description: ### Description Remove wallet::TxBuilder::allow_shrinking() and unneeded TxBuilder context param. Fixes #1374 ### Notes to the reviewers The allow_shrinking function was the only one using the TxBuilder FeeBump context and it's useful to have CreateTx context functions available for building FeeBump transactions, see updated tests. ### Changelog notice Changed - Removed TxBuilder::allow_shrinking() function. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### Bugfixes: * [x] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [x] I'm linking the issue being fixed by this PR Top commit has no ACKs. Tree-SHA512: f4f05ce4c4459fc26c0458cfec8c7101a86
11269 of 13549 relevant lines covered (83.17%)
16666.28 hits per line
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|