1
72%
master: 72%

Ran 08 May 2024 05:11AM UTC

Files 702

Run time 14s

Badge

Embed ▾

Committed 08 May 2024 04:39AM UTC coverage: 68.493% (+0.03%) from 68.462%

Job # 018f567f-6d38-4a38-bb91-2a34d52fff01.1

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Reduce flakiness on workflow-ID-specific ratelimit test (#5986)

This test had three issues:
1. it's *very* time-sensitive, spending >=200ms across all StartWorkflowExecution calls will allow one (or more) of the "should be limited" calls to succeed.  This is now more permissive.
2. it seems to misunderstand / be misleading about how ratelimits work.  The reason the first 5 calls can be done "immediately" is due to the burst value, not the RPS itself.  We just init the burst with that value.
3. if `assert.ErrorAs` failed, the next line would panic because the error value was nil.  `require` would work too, but switching to `if assert.ErrorAs(...) {...}` lets the rest of the checks continue, and it's relatively simple.

These are now fixed.

Run Details

100603 of 146880 relevant lines covered (68.49%)

2460.2 hits per line

uber / cadence / 018f567f-6d38-4a38-bb91-2a34d52fff01 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 018f567f-6d38-4a38-bb91-2a34d52fff01.1

uber / cadence / 018f567f-6d38-4a38-bb91-2a34d52fff01 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 018f567f-6d38-4a38-bb91-2a34d52fff01.1

uber / cadence / 018f567f-6d38-4a38-bb91-2a34d52fff01 / 1
72%
master: 72%

README BADGES
x