rust-bitcoin / rust-bitcoin / 8987003768 / 1
83%
master: 83%

DEFAULT BRANCH: master
Ran
Files 92
Run time 4s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.208% (+0.04%) from 83.172%
8987003768.1

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#2707: Default to forward for tagged hashes

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7685461e62beab0bcec8a96b732e58345b2640d9">7685461e6<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/594eb18728fb8a433b1045f7e9c9c507ec54349b"> Document the sha256t_hash_newtype direction (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/30e91cc766b6b1523bb8e4c93dbe74a45c097053">30e91cc76</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/594eb18728fb8a433b1045f7e9c9c507ec54349b"> Default to forward for tagged hashes (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5ecc69cd28b7cd3fc34ce0d52622f3e177a3bb02">5ecc69cd2</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/594eb18728fb8a433b1045f7e9c9c507ec54349b"> Add forward/backward unit test (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9aee65d1baf624978c2e767b059a800cc19681b5">9aee65d1b</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/594eb18728fb8a433b1045f7e9c9c507ec54349b"> Refactor tagged hash tests (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/216422dffcc7736548d37e3449ef76da1431aa6d">216422dff</a> Remove schemars impl for test type (Tobin C. Harding)

Pull request description:

  First three patches are preparation, improvements to the units tests in `sha256t`.

  From the final patch:

      Displaying backward is an anomaly of Bitcoin Core's early days and the
      double SHA256 hash type. We should not let this unfortunate beast leak
      out into other places.

      Default to displaying forward when creating a new tagged hash and remove
      all the explicit attributes from `bitcoin` that just clutter the code.

  This is an API break and may quietly break some users downstream - eventually we should stop doing that sort of thing.

ACKs for top commit:
  apoelstra:
    ACK 7685461e62beab0bcec8a96b732e58345b2640d9

Tree-SHA512: cb8a41b203859586792ecf851947c1affaa

19191 of 23064 relevant lines covered (83.21%)

16761.38 hits per line

Source Files on job 8987003768.1