1
88%
master: 88%

Ran 04 May 2016 06:51PM UTC

Files 19

Run time 15s

Badge

Embed ▾

Committed 04 May 2016 06:51PM UTC coverage: 88.013% (-0.1%) from 88.113%

Job # PATH=$HOME/gopath/bin:$PATH

Build Type

Pull #296

travis-ci

Committed by

eaburns

Commit Message

editor/view,ui: return errors preforming edits on a View.

We were returning errors from individual edits, but if the entire HTTP request failed, no error was returned, and the response channel was never notified. This caused any such error to deadlock waiting for a response that would never be sent. Now, the interface is changed to hide the underlying channel and simply return the response or an error instead.

This change also makes the ui code more explicit about whether it's doing a synchronous or asynchornous request. This is important, because we want to avoid blocking the window's event goroutine on synchronous requests, which we currently do in a few places (see #295).

Fixes #293.

Pull Request Pull Request #296: editor/view,ui: return errors preforming edits on a View.

Run Details

3884 of 4413 relevant lines covered (88.01%)

2.14 hits per line

eaburns / T / 1392 / 1
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1392.1 (PATH=$HOME/gopath/bin:$PATH)

eaburns / T / 1392 / 1 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1392.1 (PATH=$HOME/gopath/bin:$PATH)

eaburns / T / 1392 / 1
88%
master: 88%

README BADGES
x