1
78%
master: 79%

Ran 22 Apr 2024 09:55PM UTC

Files 259

Run time 9s

Badge

Embed ▾

Committed 22 Apr 2024 09:50PM UTC coverage: 68.613% (+0.003%) from 68.61%

Job # 8791384934.1

Build Type

push

github

Committed by

jrfnl

Commit Message

Tokenizer/PHP: arrow function tokenization broken when true/false used in return type

Since PHP 8.0, `false` and `null` can be included in a union return type.
As of PHP 8.2, both `true`, `false` and `null` can be used as a stand-alone return type.

The tokenizer layer handling arrow functions did not take this into account correctly. While `null` was handled correctly, `true` and `false` was not and would result in the arrow function `fn` keyword being tokenized as `T_STRING` across all PHP versions.
As a result of that, the other typical tokenizer changes related to arrow functions (`=>` as `T_FN_ARROW`, scope/parenthesis owners etc) would also not be executed correctly.

In practice, I suspect few people will have run into this bug as, after all, what's the point of declaring an arrow function which will only ever return `true` or `false` ? so in practice, it is likely to only have come into play for people using `true` or `false` as part of an arrow function union type.
All the same, PHPCS should handle this correctly.

Includes unit tests proving the bug and safeguarding the fix.

Run Details

16570 of 24150 relevant lines covered (68.61%)

19.85 hits per line

PHPCSStandards / PHP_CodeSniffer / 8791384934 / 1
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 8791384934.1

PHPCSStandards / PHP_CodeSniffer / 8791384934 / 1 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 8791384934.1

PHPCSStandards / PHP_CodeSniffer / 8791384934 / 1
78%
master: 79%

README BADGES
x