SFML / SFML / 8736987266 / 17

60%

master: 60%

push

github

Revert change to `Drawable::draw` function signature

This change was made in 359fe90 due to recommendations from tooling.
On its face this change makes sense since it removes a copy that
isn't always necessary. In practice it caused ergonomic issues due
to now being forced to make a copy of the render states when needed.

The performance gains of eliding this copy are unsubstantiated. We
have not done any profiling to measure its impact. For lack of such
measurements I'd rather err on the side of improved user experience.
If future benchmarks prove this copy is rather expensive then we
can reconsider removing it with that evidence in mind.

655 of 3001 branches covered (21.83%)

Branch coverage included in aggregate %.

2559 of 8144 relevant lines covered (31.42%)

321.65 hits per line