realm / realm-core / 2237 / 1

91%

master: 91%

push

Evergreen

Fix a race condition in Promise (#7602)

Promise needs to update `m_shared_state` before fulfilling the promise, as
`Future::get()` on another thread could return before the write occurs. If the
Promise is destroyed immediately after `get()` returns, the destructor could
then read the non-null value of `m_shared_state` before the write happens and
attempt to report a broken promise error, which hits an assertion.

94952 of 175992 branches covered (53.95%)

206239 of 229368 relevant lines covered (89.92%)

3057337.37 hits per line